| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Tomas Vondra <tomas(at)vondra(dot)me> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Alexandre Felipe <o(dot)alexandre(dot)felipe(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Georgios <gkokolatos(at)protonmail(dot)com>, Konstantin Knizhnik <knizhnik(at)garret(dot)ru>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Subject: | Re: index prefetching |
| Date: | 2026-03-12 17:27:00 |
| Message-ID: | CAH2-Wz=Qv3wmhPnryeC_TsiETP9H=btQgssSRffzJW3XmyNNXw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 12, 2026 at 10:43 AM Tomas Vondra <tomas(at)vondra(dot)me> wrote:
> I took a quick look at 0001 and 0002 patches, and I think it's mostly
> ready to go.
Pushed both patches just now. Thanks for the review!
> I only have a couple very minor comments:
>
> 1) v12-0001-Use-simple-hash-for-PrivateRefCount.patch
> - the "common/hashfn.h" include seems in the wrong place
Fixed in the pushed patch.
> 2) v12-0002-Don-t-allocate-_bt_search-stack.patch
>
> - seems like a reasonable optimization for most callers
> - _bt_search could set "stack_in = new_stack;" in the first if block, I
> think it's nicer
Agreed. Done that way in the commit that I pushed.
> - My only concern is that _bt_search is part of the public API (at least
> technically, as it's in nbtree.h), and we're removing _bt_freestack()
> from the API so the callers won't have a convenient way to free it.
> Maybe that's not an issue in practice, because doing a local version of
> freestack is easy.
I don't think that it's an issue. _bt_search is very much an
nbtree-internal function (amcheck notwithstanding), and as you point
out it's easy enough for an extension to create its own version of
_bt_freestack in the unlikely event that it needs to.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2026-03-12 17:37:14 | Re: Speed up COPY FROM text/CSV parsing using SIMD |
| Previous Message | Fujii Masao | 2026-03-12 17:24:36 | Re: Shutdown indefinitely stuck due to unflushed FPI_FOR_HINT record |