From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
---|---|
To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
Cc: | Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Disk-based hash aggregate's cost model |
Date: | 2020-09-01 21:48:07 |
Message-ID: | CAH2-Wz=Kf1q5ZSnjrfjrmkCUy+sjKpEpi014i8ZYG2PyJ7_4xA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Sep 1, 2020 at 2:19 AM Tomas Vondra
<tomas(dot)vondra(at)2ndquadrant(dot)com> wrote:
> FWIW I suspect some of this difference may be due to logical vs.
> physical I/O. iosnoop only tracks physical I/O sent to the device, but
> maybe we do much more logical I/O and it simply does not expire from
> page cache for the sort. It might behave differently for larger data
> set, longer query, ...
There is also the fact that the LogicalTapeSetBlocks() instrumentation
is known to have problems that we still need to fix:
I'm not suggesting that this is a significant factor here. But I can't
rule it out just yet either.
> I don't know. I certainly understand the desire not to change things
> this late. OTOH I'm worried that we'll end up receiving a lot of poor
> plans post release.
I think that this needs to get fixed before release.
--
Peter Geoghegan
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2020-09-01 21:58:39 | Re: Maximum password length |
Previous Message | Peter Eisentraut | 2020-09-01 21:30:11 | Re: Additional Chapter for Tutorial |