Re: Parallel bt build crashes when DSM_NONE

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Parallel bt build crashes when DSM_NONE
Date: 2018-02-12 17:26:23
Message-ID: CAH2-Wz=Arcfz50TFxSoNpR1-mSDFpy+Zxd3BtBm3FFYc5GaYyQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Feb 9, 2018 at 12:06 AM, Kyotaro HORIGUCHI
<horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> I happend to find that server crashes during regtest when
> DSM_NONE is enforced. The attached patch fixes that.
>
> The cause is the fact that _bt_spools_heapscan runs
> _bt_begin_parallel() even if dynamic_shared_memory_type is
> DSM_NONE. It is because plan_create_index_workers() is ignoring
> dynamic_shared_memory_type.

I think that your patch does the right thing.
plan_create_index_workers() is supposed to take care of parallel
safety, and this is a parallel safety issue.

Thanks
--
Peter Geoghegan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Mat Arye 2018-02-12 18:04:40 Re: Minor version upgrades and extension packaging
Previous Message Pavel Stehule 2018-02-12 17:24:04 Re: CALL stmt, ERROR: unrecognized node type: 113 bug