Re: BUG #19102: Assertion failure in generate_orderedappend_paths with aggregate pushdown

From: Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>
To: Richard Guo <guofenglinux(at)gmail(dot)com>
Cc: pgsql-bugs(at)lists(dot)postgresql(dot)org, akorotkov(at)postgresql(dot)org
Subject: Re: BUG #19102: Assertion failure in generate_orderedappend_paths with aggregate pushdown
Date: 2025-11-04 09:51:56
Message-ID: CAGz5QCLVjZBbM65E5Wkox3gO9wcLK6nwxe=GpJ6LCS3_7C_NnQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Tue, Nov 4, 2025 at 1:14 PM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:

> Here are the updated patches. I split the changes into two: 0001
> fixes the Assert failure and updates the out-of-date comment for
> generate_orderedappend_paths(), while 0002 addresses the second and
> third issues I described upthread.
>
> The assertion failure also exists in v18, so I think it would be best
> to get 0001 pushed and backpatched before the code freeze. I'm not
> sure whether 0002 should be backpatched. Before that, I'd like to
> know whether these two patches make sense.
>
Thanks for the patch.

The fix for the assert failure looks good to me. And, yes, it would be good
to backpatch this before the code freeze.

--
Thanks & Regards,
Kuntal Ghosh

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message PG Bug reporting form 2025-11-04 12:08:00 BUG #19103: Canceled INSERT statement can still influence the performance of subsequent SELECT statement
Previous Message Michael Paquier 2025-11-04 09:48:42 Re: BUG #19093: Behavioral change in walreceiver termination between PostgreSQL 14.17 and 14.18