From: | Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Error while copying a large file in pg_rewind |
Date: | 2017-07-04 06:25:05 |
Message-ID: | CAGz5QCJCXwNtnoa=a6DSSNNPAs1j4shN6YcwdP0Uu8anJK1yhg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Jul 3, 2017 at 6:50 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> pg_basebackup/ with fe_recvint64() has its own way to do things, as
> does the large object things in libpq. I would think that at least on
> HEAD things could be gathered with a small set of routines. It is
> annoying to have a third copy of the same thing. OK that's not
> invasive but src/common/ would be a nice place to put things.
>
> - if (PQgetlength(res, 0, 1) != sizeof(int32))
> + if (PQgetlength(res, 0, 1) != sizeof(long long int))
> This had better be int64.
Thank you. I'll do the changes and submit the revised patch. I've
added an entry in commitfest for the same.
--
Thanks & Regards,
Kuntal Ghosh
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2017-07-04 07:14:53 | Re: Error while copying a large file in pg_rewind |
Previous Message | Kuntal Ghosh | 2017-07-04 06:20:27 | Re: Error while copying a large file in pg_rewind |