| From: | Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Incorrect overflow check condition for WAL segment size |
| Date: | 2016-11-08 05:33:47 |
| Message-ID: | CAGz5QC+Z3z=6u+M_ex0FH4+r_u6qg89WefJRv_S5VCqw+uS+4A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi all,
Although we restrict the WAL segment size to 64 MB as upper limit, the
following piece of code in guc.c (line 715) seems confusing to me.
#if XLOG_SEG_SIZE < (1024*1024) || XLOG_BLCKSZ > (1024*1024*1024)
#error XLOG_SEG_SIZE must be between 1MB and 1GB
#endif
Either the comment is wrongly written or the check for overflow
condition has to be fixed. Assuming the overflow check condition to be
erroneous, I've attached a patch to fix this.
--
Thanks & Regards,
Kuntal Ghosh
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| wrong_wal_segment_size_upper_limit.patch | application/x-download | 513 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-11-08 05:45:59 | Re: Fix checkpoint skip logic on idle systems by tracking LSN progress |
| Previous Message | Tsunakawa, Takayuki | 2016-11-08 05:25:53 | Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled |