Re: Deleting older versions in unique indexes to avoid page splits

From: Victor Yegorov <vyegorov(at)gmail(dot)com>
To: Zhihong Yu <zyu(at)yugabyte(dot)com>
Cc: Peter Geoghegan <pg(at)bowt(dot)ie>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Deleting older versions in unique indexes to avoid page splits
Date: 2020-12-31 19:14:46
Message-ID: CAGnEbogkom5Hh+UGcu348kW+rnYfmOnauQ0T6Ao_YpdtKQECMw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

чт, 31 дек. 2020 г. в 20:01, Zhihong Yu <zyu(at)yugabyte(dot)com>:

> For v12-0001-Pass-down-logically-unchanged-index-hint.patch
>
> + if (hasexpression)
> + return false;
> +
> + return true;
>
> The above can be written as return !hasexpression;
>

To be honest, I prefer the way Peter has it in his patch.
Yes, it's possible to shorten this part. But readability is hurt — for
current code I just read it, for the suggested change I need to think about
it.

--
Victor Yegorov

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2020-12-31 19:21:55 Re: [HACKERS] [PATCH] Generic type subscripting
Previous Message Bruce Momjian 2020-12-31 19:13:07 Re: crash recovery vs partially written WAL