| From: | wenhui qiu <qiuwenhuifx(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Vectorize pg_visibility.pg_visibility_map_summary |
| Date: | 2025-12-23 04:03:31 |
| Message-ID: | CAGjGUAJa2jRepQT0BjeXtAqne-zN-bQ2wOSkrrUswzeya6W-og@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi
> It looks like a reasonable idea as it also simplifies the
> pg_visibility_map_summary() function. I'm going to push it, barring
> any objections.
Obviously no objections, Using visibilitymap_count() simplifies the code
and improves performance, with no behavior change.
Thanks
On Tue, Dec 23, 2025 at 6:17 AM Matthias van de Meent <
boekewurm+postgres(at)gmail(dot)com> wrote:
> Hi,
>
> On Mon, 22 Dec 2025 at 23:04, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
> wrote:
> > On Mon, Dec 22, 2025 at 1:28 PM Matthias van de Meent
> > <boekewurm+postgres(at)gmail(dot)com> wrote:
> > > Here's one small patch that makes it use the visibilitymap_count() API
> > > for pg_visibility_map_summary(), replacing its own bespoke counting
> > > mechanism with the primary implementation that has vectorized
> > > optimizations, thus reducing the overhead of
> > > pg_visibility_map_summary.
> > >
> >
> > It looks like a reasonable idea as it also simplifies the
> > pg_visibility_map_summary() function. I'm going to push it, barring
> > any objections.
>
> Obviously no objections from me, and, thanks!
>
>
> Kind regards,
>
> Matthias van de Meent
> Databricks (https://www.databricks.com)
>
>
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2025-12-23 04:05:11 | Re: Why is_admin_of_role() use ROLERECURSE_MEMBERS rather than ROLERECURSE_PRIVS? |
| Previous Message | zengman | 2025-12-23 03:39:14 | Re: Refactor query normalization into core query jumbling |