| From: | wenhui qiu <qiuwenhuifx(at)gmail(dot)com> |
|---|---|
| To: | Alexander Borisov <lex(dot)borisov(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Non-committer reviews: is it helpful? |
| Date: | 2026-02-02 03:58:02 |
| Message-ID: | CAGjGUAJBMc89sKWvHm2vMKD_KLuZp9tgCF=sXEbtm7mee+xK-g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
HI Alexander
Welcome, Would you be interested in reviewing this path? (
https://commitfest.postgresql.org/patch/6188/)
Thanks
On Fri, Jan 30, 2026 at 8:18 AM Alexander Borisov <lex(dot)borisov(at)gmail(dot)com>
wrote:
> 30.01.2026 02:44, Tom Lane пишет:
> > Alexander Borisov <lex(dot)borisov(at)gmail(dot)com> writes:
> >> I have a question for the community. While waiting for feedback on my
> >> own patches, I was wondering: is there value in me reviewing other
> >> people's patches, even though I am not a committer here?
> >
> > Yes, absolutely. Even if you don't catch every problem that a
> > person with committer-level experience might catch, every problem
> > you do catch is one less thing for the eventual committer to deal
> > with.
> >
> > Another reason why we encourage people of all experience levels
> > to do code reviews is that that is amazingly useful for gaining
> > familiarity with the Postgres code base, which is important for
> > becoming a more senior-level contributor. Committers don't appear
> > out of nowhere; they gained the necessary knowledge by working on
> > patches, both their own and others'.
> >
> >> I’ve been around here for over a year, and sometimes it feels like the
> >> project lacks a dedicated coordinator to direct contributor and reviewer
> >> efforts. Because of this, I'm not always sure which patches deserve
> >> attention first.
> >
> > You presume a degree of top-down organization that doesn't exist
> > around here. People work on whatever catches their fancy (or,
> > perhaps, what their company wants them to work on ... but that is no
> > business of the community at large). That applies to reviews just as
> > much as to writing the patches in the first place. So review what you
> > find interesting or what you think you can say something useful about.
>
>
> Thank you for your reply, it makes the community's approach clearer.
> Therefore, I can confidently review patches in the mailing list and
> offer my own options/edits.
> With confidence that this is really useful for the community, and the
> committers.
>
> --
> Regards,
> Alexander Borisov
>
>
>
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2026-02-02 03:58:10 | Re: splitting pg_resetwal output strings |
| Previous Message | Michael Paquier | 2026-02-02 03:54:26 | Incorrect errno used in OpenWalSummaryFile() |