Re: Support logical replication of DDLs

From: li jie <ggysxcq(at)gmail(dot)com>
To: Zheng Li <zhengli10(at)gmail(dot)com>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, rajesh singarapu <rajesh(dot)rs0541(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Japin Li <japinli(at)hotmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Support logical replication of DDLs
Date: 2022-12-09 03:31:59
Message-ID: CAGfChW4wrY2jkw+dX=mqwgEHov7kKUWmEANQ7O9TYkzeg1SLXQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

>
> Attached please find a new solution that skips the deparsing of ALTER TABLE
> subcommands generated for TableLikeClause. The patch v42-0005 added a new
> boolean field table_like to AlterTableStmt in order to identify an ALTER TABLE
> subcommand generated internally for the TableLikeClause.
>
> Regards,
> Zheng

I took a look at this patch and it appears to be incomplete.

> @@ -1974,6 +1974,7 @@ typedef struct AlterTableStmt
> List *cmds; /* list of subcommands */
> ObjectType objtype; /* type of object */
> bool missing_ok; /* skip error if table missing */
> + bool table_like; /* internally generated for TableLikeClause */
> } AlterTableStmt;

The table_like field should include implementations of the `copynode`
and `equalnode `methods.

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Zhao, Bing 2022-12-09 05:08:37 Inheritance pg_largeobject table
Previous Message li jie 2022-12-09 03:27:33 Re: Support logical replication of DDLs

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-12-09 04:16:08 Re: Allow tests to pass in OpenSSL FIPS mode
Previous Message li jie 2022-12-09 03:27:33 Re: Support logical replication of DDLs