Re: [PATCH] Expand character set for ltree labels

From: Garen Torikian <gjtorikian(at)gmail(dot)com>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Expand character set for ltree labels
Date: 2023-01-03 18:56:49
Message-ID: CAGXsc+9fV9mnpk6Oz4eNNFFh7HBMOzeAQYYLehqt5hmqYbEoAg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Sure. Rebased onto HEAD.

On Tue, Jan 3, 2023 at 7:27 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:

> On Thu, 6 Oct 2022 at 03:35, Garen Torikian <gjtorikian(at)gmail(dot)com> wrote:
> >
> > After digging into it, you are completely correct. I had to do a bit
> more reading to understand the relationships between UTF-8 and wchar, but
> ultimately the existing locale support works for my use case.
> >
> > Therefore I have updated the patch with three much smaller changes:
> >
> > * Support for `-` in addition to `_`
> > * Expanding the limit to 512 chars (from the existing 256); again it's
> not uncommon for non-English strings to be much longer
> > * Fixed the documentation to expand on what the ltree label's
> relationship to the DB locale is
>
> The patch does not apply on top of HEAD as in [1], please post a rebased
> patch:
> === Applying patches on top of PostgreSQL commit ID
> e351f85418313e97c203c73181757a007dfda6d0 ===
> === applying patch ./0002-Expand-character-set-for-ltree-labels.patch
> patching file contrib/ltree/expected/ltree.out
> patching file contrib/ltree/ltree.h
> Hunk #2 FAILED at 126.
> 1 out of 2 hunks FAILED -- saving rejects to file contrib/ltree/ltree.h.rej
>
> [1] - http://cfbot.cputube.org/patch_41_3929.log
>
> Regards,
> Vignesh
>

Attachment Content-Type Size
0003-Expand-character-set-for-ltree-labels.patch application/octet-stream 13.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2023-01-03 19:05:38 Re: recovery modules
Previous Message Robert Haas 2023-01-03 18:33:34 Re: enable_timeout_every() and fin_time