| From: | Alena Vinter <dlaaren8(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Alexander Korotkov <aekorotkov(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Resetting recovery target parameters in pg_createsubscriber |
| Date: | 2025-09-29 09:57:09 |
| Message-ID: | CAGWv16Lm8mp9pH7yHxfz_XeMBOqPFGc-vGCRtb1n_KN756oU4Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
> In short, I disagree with what you are doing here: we should take the
> extra step and clean up anything that's been created by the tool when
> we know we can safely do so
I got your point, thanks for pointing to the `pg_rewind` case. I've
attached a new version of the patches. I've changed `ReplaceRecoveryConfig`
a little bit -- now it returns false in case of an error instead of exiting.
Best wishes,
Alena Vinter
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Implements-helper-function-in-recovery_gen.patch | text/x-patch | 4.4 KB |
| v6-0003-doc-Add-warning-about-leftover-recovery-parameters-i.patch | text/x-patch | 1.9 KB |
| v6-0002-Reseting-recovery-target-parameters-in-pg_createsubs.patch | text/x-patch | 6.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2025-09-29 09:57:23 | Re: Proposal: Conflict log history table for Logical Replication |
| Previous Message | jian he | 2025-09-29 09:35:00 | CREATE TABLE LIKE INCLUDING TRIGGERS |