| From: | Alyona Vinter <dlaaren8(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Resetting recovery target parameters in pg_createsubscriber |
| Date: | 2025-09-05 05:51:12 |
| Message-ID: | CAGWv16KPjMdu2k-xc+hZcOs_8+5GyvGGtH_y13OcqOpde6e-BQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Hayato,
Thank you for the review! My apologies for the error in the patch -- it
looks like I accidentally modified it before sending =(. I've attached the
fixed versions below.
> Regarding patch content, your patch restores the postgresql.auto.conf
after the
> command runs. Initially I felt that it is enough to set below GUCs
becasue only
> they are changed from the default. Is there a reason why you fully
restore them?
I just found it easier to restore the original state of
'postgresql.auto.conf', as removing parameters from the file resets them to
their default values. This approach achieves the same final state without
having to explicitly set each one.
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0002-Implements-helper-function-in-recovery_gen.patch | text/x-patch | 3.4 KB |
| v2-0001-Reseting-recovery-target-parameters-in-pg_createsubscriber.patch | text/x-patch | 8.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-09-05 05:54:56 | Re: Appetite for syntactic sugar to match result set columns to UDT fields? |
| Previous Message | David G. Johnston | 2025-09-05 05:50:11 | Appetite for syntactic sugar to match result set columns to UDT fields? |