| From: | Alyona Vinter <dlaaren8(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Resetting recovery target parameters in pg_createsubscriber |
| Date: | 2025-09-02 12:36:57 |
| Message-ID: | CAGWv16JDyhbHKu-Eej+pL-1n9mniofK+Bq1LrW-R=Hn7Xcm+Aw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Michael and Hayato,
Thank you both for your valuable feedback on the previous patch version.
I've reworked the patch based on your suggestions - the new version should
address the concerns about ALTER SYSTEM and follows the same patterns as
the 'setup_recovery' code.
I kept primary_conninfo as-is for now since I'm not totally sure if we need
to touch it
I look forward to your feedback! ;)
Best regards,
Alyona Vinter
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Reseting-recovery-target-parameters-in-pg_createsubscriber.patch | text/x-patch | 8.8 KB |
| v2-0002-Implements-helper-function-in-recovery_gen.patch | text/x-patch | 3.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ranier Vilela | 2025-09-02 12:47:49 | Use bool with synced field (src/include/replication/slot.h) |
| Previous Message | Jim Jones | 2025-09-02 12:16:08 | Re: [PATCH] Fix ALTER SYSTEM empty string bug for GUC_LIST_QUOTE parameters |