Use bool with synced field (src/include/replication/slot.h)

From: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Use bool with synced field (src/include/replication/slot.h)
Date: 2025-09-02 12:47:49
Message-ID: CAEudQAoNit6Ngdy33W3og0zgo02_xSn8vsb21eDzH0fCRGt6Tw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi.

IMO in the struct ReplicationSlotPersistentData, the field
*synced* has wrong type declaration.
The intention was *bool* not *char* type.

Since it is only used in Boolean comparison.

trivial patch attached.

best regards,
Ranier Vilela

Attachment Content-Type Size
v1-001-use-bool-for-synced-field-slot.patch application/octet-stream 433 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2025-09-02 12:48:43 Re: Serverside SNI support in libpq
Previous Message Alyona Vinter 2025-09-02 12:36:57 Re: Resetting recovery target parameters in pg_createsubscriber