| From: | Claudio Freire <klaussfreire(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>, Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: ParallelFinish-hook of FDW/CSP (Re: Steps inside ExecEndGather) |
| Date: | 2017-02-24 16:40:49 |
| Message-ID: | CAGTBQpZUvb6MYHtUqGYgi=AurdL-+5d37GmHhE4BGOaahu_FBA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Feb 24, 2017 at 1:24 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Fri, Feb 24, 2017 at 7:29 PM, Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp> wrote:
>> This attached patch re-designed the previous v2 according to Robert's comment.
>> All I had to do is putting entrypoint for ForeignScan/CustomScan at
>> ExecShutdownNode,
>> because it is already modified to call child node first, earlier than
>> ExecShutdownGather
>> which releases DSM segment.
>
> Aside from the documentation, which needs some work, this looks fine
> to me on a quick read.
LGTM too.
You may want to clarify in the docs when the hook is called in
relation to other hooks too.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2017-02-24 16:58:16 | Re: Patch: Write Amplification Reduction Method (WARM) |
| Previous Message | David Fetter | 2017-02-24 16:35:30 | Re: Make subquery alias optional in FROM clause |