Re: Vacuum: allow usage of more than 1GB of work mem

From: Claudio Freire <klaussfreire(at)gmail(dot)com>
To: Anastasia Lubennikova <lubennikovaav(at)gmail(dot)com>
Cc: PostgreSQL-Dev <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Vacuum: allow usage of more than 1GB of work mem
Date: 2016-12-22 18:18:07
Message-ID: CAGTBQpYWmVw=MDvJJvK9dm42dg8HU3XO=TS1+EhyUSTQMwbwYw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Thu, Dec 22, 2016 at 12:22 PM, Claudio Freire <klaussfreire(at)gmail(dot)com> wrote:
> On Thu, Dec 22, 2016 at 12:15 PM, Anastasia Lubennikova
> <lubennikovaav(at)gmail(dot)com> wrote:
>> The following review has been posted through the commitfest application:
>> make installcheck-world: tested, failed
>> Implements feature: not tested
>> Spec compliant: not tested
>> Documentation: not tested
>>
>> Hi,
>> I haven't read through the thread yet, just tried to apply the patch and run tests.
>> And it seems that the last attached version is outdated now. It doesn't apply to the master
>> and after I've tried to fix merge conflict, it segfaults at initdb.
>
>
> I'll rebase when I get some time to do it and post an updated version

Attached rebased patches. I called them both v3 to be consistent.

I'm not sure how you ran it, but this works fine for me:

./configure --enable-debug --enable-cassert
make clean
make check

... after a while ...

=======================
All 168 tests passed.
=======================

I reckon the above is equivalent to installcheck, but doesn't require
sudo or actually installing the server, so installcheck should work
assuming the install went ok.

Attachment Content-Type Size
0001-Vacuum-prefetch-buffers-on-backward-scan-v3.patch text/x-patch 2.5 KB
0002-Vacuum-allow-using-more-than-1GB-work-mem-v3.patch text/x-patch 20.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-12-22 18:33:39 Read/write expanded objects versus domains and CASE
Previous Message Tomas Vondra 2016-12-22 18:08:43 Re: increasing the default WAL segment size