Re: Is tuplesort_heap_siftup() a misnomer?

On Thu, Sep 8, 2016 at 4:20 PM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
> On Thu, Sep 8, 2016 at 10:40 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> On Thu, Sep 8, 2016 at 12:01 AM, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>>>> I still think tuplesort_heap_siftup is a confusing name, although I'm not
>>>> sure that Peter's "compact" is much better. I suggest that we rename it to
>>>> tuplesort_heap_delete_top(). In comments within the function, explain that
>>>> the *loop* corresponds to the "siftup" in Knuth's book.
>>
>>> I'm also fine with that name.
>>
>> I can live with it too.
>
> Attached patch does it that way, then. I stuck with the reference to
> "shift down", though, since I think we all agree that that is
> unambiguous.

I believe the term is "sift" not "shift"