Re: Using make_ctags leaves tags files in git

From: Steve Chavez <steve(at)supabase(dot)io>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Using make_ctags leaves tags files in git
Date: 2023-05-15 00:00:40
Message-ID: CAGRrpzb1RUOan+ST=UUB-PXY-NDv0tZjiEpmwU_mk6iGVniZyA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello Michael,

On the previous patch:

- `.*.swp` was added, which I entirely agree shouldn't be in .gitignore as
it's editor specific(despite me using vim).
- The discussion dabbled too much around the *.swp addition.

In this case I just propose adding 'tags'. I believe it's reasonable to
ignore these as they're produced by make_ctags.

Best regards,
Steve

On Sun, 14 May 2023 at 20:44, Michael Paquier <michael(at)paquier(dot)xyz> wrote:

> On Sun, May 14, 2023 at 06:13:21PM -0300, Steve Chavez wrote:
> > I use postgres/src/tools/make_ctags and it works great. But it leaves the
> > tags files ready to be committed in git. So, I've added 'tags' to
> > .gitignore.
>
> This has been proposed in the past, where no conclusion was reached
> about whether this would be the best move (backup files from vim or
> emacs are not ignored, either):
>
> https://www.postgresql.org/message-id/CAFcNs+rG-DASXzHcecYKvAj+rmxi8CpMAgbpGpEK-mjC96F=Lg@mail.gmail.com
>
> And there are global rules, as well.
> --
> Michael
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-05-15 00:18:32 Re: Allow pg_archivecleanup to remove backup history files
Previous Message Michael Paquier 2023-05-14 23:53:32 Re: check_GUC_init(wal_writer_flush_after) fails with non-default block size