Re: BUG #18258: The redo of the drop db wal needs to forward the Min Recovery Point

From: shihao zhong <zhong950419(at)gmail(dot)com>
To: azurezhao8369(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Cc: Noah Misch <noah(at)leadboat(dot)com>
Subject: Re: BUG #18258: The redo of the drop db wal needs to forward the Min Recovery Point
Date: 2026-11-10 03:29:45
Message-ID: CAGRkXqTwa2dWjWhhVG+rWyD2BDoiOhOXsyBmk2Ym-CEV7F_1Mw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Hi,

I found this bug on Noah's wanted list [1], so here is a patch. I can
reproduce it on master. If the standby restarts after replaying the
drop record, it reaches consistency too early and then fails with:

PANIC: WAL contains references to invalid pages

DROP TABLESPACE and ALTER DATABASE SET TABLESPACE have the same gap.
The patch calls XLogFlush() before the files are removed, like
xact_redo_commit() does. The new TAP test fails without the fix and
passes with it.

Thanks,
Shihao

[1] https://wiki.postgresql.org/wiki/User:Nmisch/Wanted

Attachment Content-Type Size
v1-0002-Add-test-for-minRecoveryPoint-after-drop-redo.patch application/octet-stream 3.7 KB
v1-0001-Update-minRecoveryPoint-before-removing-files-in-dro.patch application/octet-stream 2.1 KB

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Corey Huinker 2026-11-10 03:49:38 Re: BUG #19842: pg_restore_extended_stats() rejects a faithful pg_dump of ANALYZE-produced range expression statisti
Previous Message shihao zhong 2026-11-09 23:09:19 Re: BUG #19849: queries fail after ANALYZE with expression stats on arrays