Re: [PG19] eager aggregation gives wrong results because of bpchar_ops

From: shihao zhong <zhong950419(at)gmail(dot)com>
To: Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Guofenglinux <guofenglinux(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: [PG19] eager aggregation gives wrong results because of bpchar_ops
Date: 2026-10-07 01:31:53
Message-ID: CAGRkXqTaqTXVewC6+MddROyipeAWYg6kDkQgg6jCYXTr=zJBxw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Peter,

> Something like the attached seems like it'd do the job.

I tried it. I took a pg_dumpall from a 13 cluster after the
regression tests, ran 002_pg_upgrade.pl on master with it, and then
ran amcheck on the upgraded cluster. Without the patch amcheck
complains with the following. With the patch it is clean.

`ERROR: index "ctl_bpchar" metapage incorrectly indicates that
deduplication is safe`

Thanks,
Shihao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2026-10-07 01:43:46 Re: Fix reindexdb with parallel index-level conrurrent run
Previous Message Richard Guo 2026-10-07 01:30:29 Re: pgsql: Teach expr_is_nonnullable() to handle more expression types