Re: Fire create_upper_paths_hook for UPPERREL_PARTIAL_GROUP_AGG

From: shihao zhong <zhong950419(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Himanshu Upadhyaya <upadhyaya(dot)himanshu(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Andrew Dunstan <amdunstan(at)gmail(dot)com>
Subject: Re: Fire create_upper_paths_hook for UPPERREL_PARTIAL_GROUP_AGG
Date: 2026-09-08 04:25:02
Message-ID: CAGRkXqTXkifFpDFq33x3mXtvimop4chpn_HFRPv=zsTEM0fNsA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> It's a good idea to write something like this to convince yourself
> that the hook is usable for something useful, but that doesn't mean
> we need to carry that proof in-tree forevermore.

You're right. The test only checks that the hook gets called. It
doesn't check that anything behaves differently, and that isn't worth
spinning up a session for. Writing it did convince me the hook is
usable, like you say, but that doesn't mean it has to stay in the tree.
Dropping 0002.

I should also correct what I wrote about it. That description was from
an different version which added a path and checked that the planner
gathered it and built Finalize Aggregate on top. Even that is existing
planner behavior, not something 0001 adds.

Review is otherwise unchanged. I only have the Nit commit message and
comment suggestions from my earlier mail.

Given there is no major feedback open, I change the patch to Ready for
Committer.

Thanks,
Shihao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2026-09-08 04:35:35 Re: Missing dshash cleanup in pgstat_read_statsfile() after OOM
Previous Message Hayato Kuroda (Fujitsu) 2026-09-08 04:22:43 RE: Follow-up review items for update_deleted