| From: | shihao zhong <zhong950419(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, joel(at)compiler(dot)org, arseniy(dot)mukhin(dot)dev(at)gmail(dot)com |
| Subject: | Re: [PG19] A canceled notify read leaves the NOTIFY queue stuck |
| Date: | 2026-10-26 15:52:07 |
| Message-ID: | CAGRkXqSMjTEyz64n9wBkKKz-3G-ObV9nad891iGc7YN60Hg3UA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Tom,
> I don't like that choice at all. The only callers of
> GetSnapshotData() are in snapmgr.c and predicate.c, and there are
> enough weird optimization-driven assumptions around snapshot
> management that I think any new caller had better be in one of those
> modules so that people working in that area will notice it.
It seems we had different understandings of encapsulation. After some
careful thought and looking through some previous commits in snapmgr.c
(with Claude), I agree that centralizing snapshot management is better than
having every caller maintain its own snapshot object.
So I think we should go with your patch.
Thanks,
Shihao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Burd | 2026-10-26 15:57:23 | Re: Let's drop support for named POSIX semaphores |
| Previous Message | Greg Burd | 2026-10-26 15:49:10 | Re: Hash index inserts serialise on the metapage tuple counter |