Re: BUG #19686: Rolling back SET TABLESPACE

From: shihao zhong <zhong950419(at)gmail(dot)com>
To: Manu <manuelreyesbravo(at)gmail(dot)com>
Cc: Alexandre Felipe <o(dot)alexandre(dot)felipe(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #19686: Rolling back SET TABLESPACE
Date: 2026-10-02 03:27:22
Message-ID: CAGRkXqSFUpNaYXt_EOiG9wNzXK6GCGaHZviGryfGRczJ-GqNfA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Manu,

I reviewed v2 and it looks correct. I asked Fable to test rollback,
savepoints, 2PC, crash recovery and a standby, and they all pass. The
test fails without the fix.

v2 also fixes SET TABLESPACE, TRUNCATE, ROLLBACK, which empties the
index on master.

Alexandre's full tablespace case does fail with v2. Moving the
indexes first works.

It applies to 16 and up. 14 and 15 need the old RelFileNode names.

Thanks,
Shihao

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Zhijie Hou 2026-10-02 03:33:16 Re: Fix apply worker crash when subscriber table has only a deferrable primary key
Previous Message Joao Detomini 2026-10-02 03:11:03 Re: tuplesort_putdatum() does not account for tuple memory