Re: Avoid truncated or zero-padded copies of replaced files in backups.

From: shihao zhong <zhong950419(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: David Steele <david(at)pgbackrest(dot)org>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: Avoid truncated or zero-padded copies of replaced files in backups.
Date: 2026-10-26 04:40:56
Message-ID: CAGRkXqSBNLdkd_2us-uOGQBV0LW7uLsAeAMRXbDuefh1XuS_yQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Michael,

> Saying that, could you adjust the 2PC file? I'd just fix that now
> and be done with it..

Here it is, with David's points addressed. The temp file is renamed
into place and restoreTwoPhaseData() removes stale ones at startup.

Thanks,
Shihao

Attachment Content-Type Size
nocfbot-twophase-tmp-rename-REL14-16.txt text/plain 4.0 KB
nocfbot-twophase-tmp-rename-master.txt text/plain 4.1 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2026-10-26 04:41:06 Re: Do not fail WAL buffers read after on-disk xlog removal
Previous Message David G. Johnston 2026-10-26 04:29:39 Re: Event trigger table rewrite doc missing ALTER MATERIALIZED VIEW case