Re: Incremental backup can use a summary past a timeline switch

From: shihao zhong <zhong950419(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Manu <manuelreyesbravo(at)gmail(dot)com>, Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Incremental backup can use a summary past a timeline switch
Date: 2026-11-01 00:56:33
Message-ID: CAGRkXqS5sX0qu=o1MUqC+D59hcuzqTEbDRe6Dnf4m8dpCZXrFQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Fujii,

+1 to commit this patch first.

It does not cover one more case. If the recovery target is not at a
checkpoint redo, a timeline 1 summary can go past the switch point,
and a truncation after that point still drops blocks. This is the
case from the "Assertion failure in WAL summarizer" thread [1], and
Manu's 0002 there fixes it on top of this patch.

[1] https://postgr.es/m/179296590548.3326877.13182798945037392623@gmail.com

Thanks,
Shihao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message shihao zhong 2026-11-01 01:05:27 Hash index corruption and CLOG lookup errors from checkpoint races
Previous Message Manu 2026-11-01 00:55:34 Re: O(N^3) planning time in choose_plan_name() since 8c49a484e8e