Re: [PATCH] pageinspect: validate line pointers before using them

From: shihao zhong <zhong950419(at)gmail(dot)com>
To: Greg Burd <gregburd(at)protonmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] pageinspect: validate line pointers before using them
Date: 2026-10-21 00:35:16
Message-ID: CAGRkXqRvZgnOZJZr2dETFAcp1u-qXkMnj_cy5eOXRg5dGbY1AA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Greg,

Thanks for testing this. I reproduced your TRAP on a cassert build with
both patches applied.

v3 folds your change into 0001, with a Co-authored-by line for you.

I also added a btree regression test that sets LP_DEAD on the high key of
a multi-page index. It crashes without 0003 and gives the new error with it.

Thanks,
Shihao

Attachment Content-Type Size
v3-0001-pageinspect-validate-line-pointers-before-using-t.patch application/octet-stream 11.9 KB
v3-0002-pageinspect-validate-page-headers-and-BRIN-and-GI.patch application/octet-stream 11.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message shihao zhong 2026-10-21 00:39:11 Re: [PG19] Promotion hangs behind a backend blocked on a stuck client
Previous Message David Rowley 2026-10-21 00:33:54 Re: Fix integer truncation in frontend pnstrdup()