Re: [PG19] Hash join writes null-keyed outer rows to temp files

From: shihao zhong <zhong950419(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PG19] Hash join writes null-keyed outer rows to temp files
Date: 2026-10-23 01:21:39
Message-ID: CAGRkXqQyBbJATKX4mMxeLL0ZpRbY6N44k=fB7gCVZRMa+P1HMw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi

Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> I like this idea substantially better. More or less as attached?

Yes, thanks for writing it.

It passed all the local tests I had before and the performance is
back.

One small thing. Looks like HJ_FILL_OUTER_NULL_TUPLES can
now only be reached in a parallel join, so maybe add
Assert(parallel) there.

Thanks,
Shihao

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2026-10-23 01:25:25 Re: [PG19] Hash join writes null-keyed outer rows to temp files
Previous Message shihao zhong 2026-10-23 01:16:51 Re: Trying out <stdatomic.h>