| From: | shihao zhong <zhong950419(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Tomas Vondra <tomas(at)vondra(dot)me>, 1217816127(at)qq(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org, PG Bug reporting form <noreply(at)postgresql(dot)org> |
| Subject: | Re: BUG #19763: ManualBug2 NULL pointer dereference in make_build_data via examine_expression bypass of lookup_var_a |
| Date: | 2026-10-21 00:29:28 |
| Message-ID: | CAGRkXqQWF+p5O46uh-4aRQQr5135RZr=91UArf+eijOaUv1JCw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Hi Michael,
> I think that we should just ditch this comment.
Done.
> This warning is a duplicate, FWIW.
v2 moves it into a small function, so there is only one copy.
> If we begin to care about examine_expression(), I think that we
> ought to also care about build_expr_data(), its second caller, no?
Yes, it can be reached. With a typanalyze function that only accepts the
first call with a real target, ANALYZE crashes in compute_expr_stats().
v2 checks the result there too and skips the object with the same
warning. I did not add a test for it, since it needs another fancy
callback.
> This test is a duplicate of the first one.
Removed.
Thanks,
Shihao
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Handle-failed-typanalyze-when-building-extended-s.patch | application/octet-stream | 9.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shihao zhong | 2026-10-21 00:45:45 | Re: GIN jsonb_ops misses root strings in strict jsonpath queries |
| Previous Message | Kirill Reshke | 2026-10-20 21:11:32 | Re: Timing issue in pg_basebackup |