Re: [PATCH] Runtime control of CLOBBER_CACHE_ALWAYS

From: Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com>
To: Craig Ringer <craig(at)2ndquadrant(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Runtime control of CLOBBER_CACHE_ALWAYS
Date: 2020-12-10 03:00:42
Message-ID: CAGRY4nxRH+WAJsie_=RsA4CnqST4mP9rgeERr79Zmz8okh1tbw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 3 Dec 2020 at 15:53, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:

>
> On Tue, 27 Oct 2020 at 16:34, Peter Eisentraut <
> peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>
>> On 2020-09-25 09:40, Craig Ringer wrote:
>> > While working on extensions I've often wanted to enable cache
>> clobbering
>> > for a targeted piece of code, without paying the price of running it
>> for
>> > all backends during postgres startup and any initial setup tasks that
>> > are required.
>> >
>> > So here's a patch that, when CLOBBER_CACHE_ALWAYS or
>> > CLOBBER_CACHE_RECURSIVE are defined, adds a GUC named
>> > clobber_cache_depth . It defaults to 1 for CLOBBER_CACHE_ALWAYS or 3
>> for
>> > CLOBBER_CACHE_RECURSIVE to match the existing compiled-in behaviour.
>> But
>> > with this change it's now possible to run Pg with clobber_cache_depth=0
>> > then set it to 1 only for targeted tests.
>>
>> I think it would be great if the cache clobber code is always compiled
>> in (but turned off) when building with assertions. The would reduce the
>> number of hoops to jump through to actually use this locally and reduce
>> the number of surprises from the build farm.
>
>
>
Updated per your comments Peter, see mail immediately up-thread.

Moved to this CF as https://commitfest.postgresql.org/31/2749/ .

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2020-12-10 03:02:26 Re: Refactor MD5 implementations and switch to EVP for OpenSSL
Previous Message tsunakawa.takay@fujitsu.com 2020-12-10 02:46:08 RE: [Patch] Optimize dropping of relation buffers using dlist