| From: | Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: change in behaviour for format_type() call |
| Date: | 2018-03-02 05:10:55 |
| Message-ID: | CAGPqQf2yMSMck1BV++RiH=yRGmoO4tX8nWQ1WKBjXa-=3T3VQw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 1, 2018 at 10:10 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I wrote:
> > I don't see anything in the commit message or linked discussion to
> > indicate that any visible behavior change was intended, so I think
> > you're right, this is a bug. Will check and push your patch.
>
> Actually, this patch still wasn't quite right: although it fixed
> one aspect of the behavior, it still produced identical results
> for typemod NULL and typemod -1, which as the function's comment
> explains is not what should happen. I tweaked the logic to look
> as much as possible like before, and added a regression test.
>
Thanks Tom.
Regards,
Rushabh Lathia
www.EnterpriseDB.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2018-03-02 05:20:03 | Re: Failed to request an autovacuum work-item in silence |
| Previous Message | Yoshimi Ichiyanagi | 2018-03-02 05:01:24 | Re: [HACKERS][PATCH] Applying PMDK to WAL operations for persistent memory |