From: | Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: invalid memory alloc request size error with commit 4b93f579 |
Date: | 2018-02-27 01:57:45 |
Message-ID: | CAGPqQf2xKmG76rE14ZG7hg+je+why03sgG2cQ=rLS+NXDdJ40g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Thanks Tom.
On Tue, Feb 27, 2018 at 2:55 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I wrote:
> > I wonder whether it is worth creating a C trigger function
> > (probably in regress.c) specifically to exercise this situation.
>
> Actually, that doesn't seem too bad at all. I propose applying
> and back-patching the attached.
>
>
Patch looks good to me.
> BTW, I noticed while doing this that the adjacent "funny_dup17"
> trigger is dead code, and has been since commit 1547ee01 of
> 1999-09-29. I'm inclined to rip it out, because anyone looking
> at regress.c would naturally assume that anything in there is
> being exercised.
>
> regards, tom lane
>
>
--
Rushabh Lathia
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2018-02-27 02:04:15 | Re: jsonlog logging only some messages? |
Previous Message | Thomas Munro | 2018-02-27 01:52:02 | Re: Unexpected behavior with transition tables in update statement trigger |