From: | Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com> |
---|---|
To: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Error during restore - dump taken with pg_dumpall -c option |
Date: | 2016-05-12 08:20:09 |
Message-ID: | CAGPqQf2T5oQRZjqy4r1fpZz6SvERCdccfUopba8KCtt8XYospw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On master branch when we do pg_dumpall with -c option, I can see that
it also dumping the "DROP ROLE pg_signal_backend", which seems wrong.
Because when you restore the dump, its throwing an error
"ERROR: cannot drop role pg_signal_backend because it is required by the
database system".
dumpRoles()::pg_dumpall.c does have logic to not dump "CREATE ROLE" if the
rolename starts with "pg_", but similar check is missing into dropRoles()
function.
PFA patch, to fix the problem in the similar way its been handled into
dumpRoles().
Thanks,
--
Rushabh Lathia
www.EnterpriseDB.com
Attachment | Content-Type | Size |
---|---|---|
pgdump_droprole_fix.patch | application/x-patch | 937 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Sameer Thakur-2 | 2016-05-12 08:42:29 | Re: Declarative partitioning |
Previous Message | Michael Banck | 2016-05-12 07:47:02 | Re: Academic help for Postgres |