From: | Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Peter Geoghegan <peter(at)2ndquadrant(dot)com> |
Subject: | Re: assertion failure w/extended query protocol |
Date: | 2012-10-22 05:24:03 |
Message-ID: | CAGPqQf0MW9d1CKwyDy0f2-bTcE01KiNNGgsMDtD=Ybzw=CeJjg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Sorry It might be late here, but just wanted to share the patch
I came up with. Actually with Robert told he reported issues to
pgsql-hacker, I thought he might have also submitted patch.
PFA I came up with, but seems like issue has been already
committed.
Thanks,
On Sat, Oct 20, 2012 at 9:07 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> > On Saturday, October 20, 2012 12:05:15 AM Tom Lane wrote:
> >> (such as the current query showing up in pg_cursors --- maybe we should
> >> prevent that?)
>
> > I don't really see an argument for preventing that.
>
> Well, the reason it seems peculiar to me is that the current query is in
> no way a cursor --- it's just a SELECT in the cases that showed
> regression test differences. I didn't go looking in the code yet, but
> I suspect the pg_cursors view is displaying all Portals. Arguably, it
> should only display those that were created by actual cursor commands.
>
> regards, tom lane
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>
--
Rushabh Lathia
Attachment | Content-Type | Size |
---|---|---|
assertion_pg.patch | application/octet-stream | 1.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2012-10-22 08:39:28 | Re: [WIP PATCH] for Performance Improvement in Buffer Management |
Previous Message | Vik Reykja | 2012-10-22 03:23:35 | Re: Re: [PATCH] Enforce that INSERT...RETURNING preserves the order of multi rows |