Re: incorrect error message, while dropping PROCEDURE

From: Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: incorrect error message, while dropping PROCEDURE
Date: 2017-12-15 02:49:45
Message-ID: CAGPqQf0LKKE0S5Ew=zO8AQM=ZbR=xnhY2n+hRawYDU1dq1HMUQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Dec 15, 2017 at 3:32 AM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
wrote:

> On Fri, Dec 15, 2017 at 12:18 AM, Peter Eisentraut
> <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> > On 12/13/17 23:31, Rushabh Lathia wrote:
> >> PFA patch, where introduced new AclObjectKind (ACL_KIND_PROCEDURE),
> >> msg for the new AclObjectKind, and passed it through at
> >> appropriate places.
> >
> > Yeah, that's a way to do it, but having both ACL_KIND_PROC and
> > ACL_KIND_PROCEDURE is clearly confusing. The above-mentioned patch
> > cleans that up more thoroughly, I think.
>
> +1. I looked at the patch of Peter, as well as this one, and I prefer
> Peter's approach of reducing duplications in concepts.
>

Yes, I also agree.

Thanks,

--
Rushabh Lathia

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2017-12-15 02:52:35 Re: pearltidy source code has been removed (pgindent)
Previous Message John Naylor 2017-12-15 02:36:07 Re: pearltidy source code has been removed (pgindent)