Re: DROP OWNED BY is broken on master branch.

From: Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: DROP OWNED BY is broken on master branch.
Date: 2022-09-28 12:20:53
Message-ID: CAGPqQf0=NODZiU5LfL4F+48vp0OOqfxYAW2qiCagZ7=DHc2RVg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 27, 2022 at 7:34 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> On Tue, Sep 27, 2022 at 2:53 AM Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>
> wrote:
> > Yes, I was also thinking to avoid the duplicate logic but couldn't found
> > a way. I did the quick testing with the patch, and reported test is
> working
> > fine. But "make check" is failing with few failures.
>
> Oh, woops. There was a dumb mistake in that version -- it was testing
> sdepForm->dbid == SHARED_DEPENDENCY_OWNER, which is nonsense, instead
> of sdepForm->dbid == MyDatabaseId. Here's a fixed version.
>

This seems to fix the issue and in further testing I didn't find anything
else.

Thanks,

> --
> Robert Haas
> EDB: http://www.enterprisedb.com
>

--
Rushabh Lathia

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2022-09-28 12:26:53 Re: longfin and tamandua aren't too happy but I'm not sure why
Previous Message Dilip Kumar 2022-09-28 11:52:28 Re: longfin and tamandua aren't too happy but I'm not sure why