| From: | Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Changing types of block and chunk sizes in memory contexts |
| Date: | 2023-07-14 06:53:24 |
| Message-ID: | CAGPVpCTwR408DEm++fXo6qZsKNbJr7B9Cw5mRtO_hp-XTiweyQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi David,
David Rowley <dgrowleyml(at)gmail(dot)com>, 13 Tem 2023 Per, 08:04 tarihinde şunu
yazdı:
> I looked at your v2 patch. The only thing that really looked wrong
> were the (Size) casts in the context creation functions. These should
> have been casts to uint32 rather than Size. Basically, all the casts
> do is say to the compiler "Yes, I know this could cause truncation due
> to assigning to a size smaller than the source type's size". Some
> compilers will likely warn without that and the cast will stop them.
> We know there can't be any truncation due to the Asserts. There's also
> the fundamental limitation that MemoryChunk can't store block offsets
> larger than 1GBs anyway, so things will go bad if we tried to have
> blocks bigger than 1GB.
>
Right! I don't know why I cast them to Size. Thanks for the fix.
Best,
--
Melih Mutlu
Microsoft
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2023-07-14 07:13:17 | Re: remaining sql/json patches |
| Previous Message | Ashutosh Bapat | 2023-07-14 06:51:17 | Re: logical decoding and replication of sequences, take 2 |