| From: | Oliver Ford <ojford(at)gmail(dot)com> |
|---|---|
| To: | Douglas Doole <dougdoole(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add Roman numeral conversion to to_number |
| Date: | 2017-09-18 12:39:25 |
| Message-ID: | CAGMVOdu9G3sP4oX5f0dOrL-BDBpyn-gNm3pVcdXdHHXX=munoQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Sep 17, 2017 at 12:29 AM, Douglas Doole <dougdoole(at)gmail(dot)com> wrote:
> I finally figured out why docs weren't building on my machine so I was able
> to take a look at your doc patch too. I think it's fine.
>
> Reading it did suggest a couple extra negative tests to confirm that when
> 'rn' is specified, all other elements are ignored:
>
> select to_number('vii7', 'rn9');
> select to_number('7vii', '9rn');
>
>
Attached is v2 of src, tests and docs. Doc patch is unchanged from v1.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-roman-src-v2.patch | application/octet-stream | 5.7 KB |
| 0002-roman-tests-v2.patch | application/octet-stream | 147.9 KB |
| 0003-roman-docs-v2.patch | application/octet-stream | 913 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gaddam Sai Ram | 2017-09-18 12:40:30 | Re: Error: dsa_area could not attach to a segment that has been freed |
| Previous Message | Ashutosh Bapat | 2017-09-18 12:02:06 | Re: Partition-wise join for join between (declaratively) partitioned tables |