| From: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: get rid of Pointer type, mostly |
| Date: | 2025-11-24 17:30:04 |
| Message-ID: | CAGECzQTZYKBZmT=0DLPhVntoC4OAqtUBdHu8V+_-7cnckfFe5w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 24, 2025, 09:34 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Especially so if the removal is incomplete. What have
> you really accomplished then?
>
In this case, what we would accomplish is that no new developer to the
project has to understand what some unclear typedef means, *unless* they
touch GIN related code. Just from its name it's definitely not clear to me
that Pointer means char * instead of void *. And this typedef is ven
shorter than the thing it represents.
Side annoyance: I think this is a falacy that hackers discussions end up in
a lot. Someone suggesting that the partial improvements have (almost) no
benefit and all cases need to be fixed in one go to before it should be
committed. Then the patch author thinks that's too much work and then
nothing ends up being improved at all.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2025-11-24 17:32:25 | Re: get rid of Pointer type, mostly |
| Previous Message | Andrew Dunstan | 2025-11-24 17:26:58 | Re: Cygwin support |