| From: | Jelte Fennema <postgres(at)jeltef(dot)nl> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Noah Misch <noah(at)leadboat(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Bruce Momjian <bruce(at)momjian(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Jesse Zhang <sbjesse(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: run pgindent on a regular basis / scripted manner |
| Date: | 2023-02-13 14:02:39 |
| Message-ID: | CAGECzQTGVef30yn=Yvs+dVWoOR2X0b2oLbrJxo36-3tyn1VnOQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, 12 Feb 2023 at 15:16, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> I'm not sure how much more I really want to do here. Given the way pgindent now processes command line arguments, maybe the best thing is for people to use that. Use of git aliases can help. Something like these for example
>
>
> [alias]
>
> dirty = diff --name-only --diff-filter=ACMU -- .
> staged = diff --name-only --cached --diff-filter=ACMU -- .
> dstaged = diff --name-only --diff-filter=ACMU HEAD -- .
>
>
> and then you could do
>
> pgindent `git dirty`
>
>
> The only danger would be if there were no dirty files. Maybe we need a switch to inhibit using the current directory if there are no command line files.
>
>
> Thoughts?
I think indenting staged or dirty files is probably the most common
operation that people want to do with pgindent. So I think that having
dedicated flags makes sense. I agree that it's not strictly necessary
and git aliases help a lot. But the git aliases require you to set
them up. To me making the most common operation as easy as possible to
do, seems worth the few extra lines to pgindent.
Sidenote: You mentioned untracked files in another email. I think that
the --dirty flag should probably also include untracked files. A
command to do so is: git ls-files --others --exclude-standard
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Luzanov | 2023-02-13 14:06:02 | Re: [EXTERNAL] Re: [PATCH] Support using "all" for the db user in pg_ident.conf |
| Previous Message | Justin Pryzby | 2023-02-13 13:50:53 | Re: amvalidate(): cache lookup failed for operator class 123 |