Re: New commitfest app release on August 19th

From: Jelte Fennema-Nio <me(at)jeltef(dot)nl>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: New commitfest app release on August 19th
Date: 2025-08-11 07:39:14
Message-ID: CAGECzQSENxrpLHUNCmBKM-On4x7LAw1npOgdwYyoFjQCksBmCQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 8 Aug 2025 at 11:55, Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
> Nice stuff.

Thanks for all the feedback. It's super helpful.

> I tried the search, works great, hadn't noticed it before
> though now I see it was there already. Maybe the result page could be
> improved still, for instance
> https://commitfest-test.postgresql.org/search/?searchterm=psql
> shows a long list of patches in which it's hard to see which ones are
> current, which were Committed, which ones were Returned with Feedback.
> (The latter is extremely useful to find old items that were neglected --
> I do that all the time, manually, very annoying.)

Indeed I just moved the box around this time. It's probably not too
hard to allow searching globally. So I created an issue to track it:
https://github.com/postgres/pgcommitfest/issues/92

> I hope more widespread use of tags will one day release us from having
> the "Topic" categorization, which is not all that useful anymore.

Yeah, that's something I intend to try out soonish.

> Two minor comments: the tags in the patch page
> https://commitfest-test.postgresql.org/patch/5501/
> are not clickable, so I can't go to other patches containing the same
> tags as this one. This sounds like a trivial fix. Tags are already
> clickable in other pages.

It's not entirely trivial I guess: What CF should those buttons link
to? The In Progress CF, the Open CF or the last CF that

> The other one I noticed while looking at the prod Draft-CF a couple of
> days ago. Here:
> https://commitfest-test.postgresql.org/54/
> I think the "Closed patches" in the draft CF should not list the patches
> that were moved to a future non-draft CF -- that's clutter and serves no
> purpose. It still makes sense to list the Draft-CF in the "Status"
> section of the patch page itself. (Eh, now I notice that the help page
> says at the bottom "Another difference between Draft CommitFests and
> regular CommitFests is that Draft CommitFests don't list resolved
> patches." which is kinda not true)

I think that's fair. How about I simply remove the closed patches
section in Draft CFs completely and make sure a closed/completed patch
is always moved to the open CF? Or do you see any reason to keep the
section?

> Not a fan of the high-contrast buttons (the new black/white elements in
> the navigation bar). It feels odd to have everything in gray, except a
> too-notorious blue Github button.

I'll see if I can make the styling of the buttons a bit better.

> IMO that button is also too wide --
> if I keep the browser window of the same width I typically use (half the
> screen) then the menu at the top disappears and is replaced with the
> hamburger button, and so becomes unusable.

Pushed a fix for that now.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ajin Cherian 2025-08-11 08:05:43 Re: Improve pg_sync_replication_slots() to wait for primary to advance
Previous Message Jelte Fennema-Nio 2025-08-11 06:58:41 Re: BackendKeyData is mandatory?