Re: pg_get__*_ddl consolidation

From: Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Japin Li <japinli(at)hotmail(dot)com>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_get__*_ddl consolidation
Date: 2026-04-05 16:35:34
Message-ID: CAGECzQRyh9Yf87sMgBaYjaas7yx5R91ga5JjJxAx3W_Uu8BfUA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, 5 Apr 2026 at 17:06, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> Pushed. I have moved the remaining get_*_ddl items to PG20-1

+1 on having this feature in general. But I'm not sure I understand
why it needs the whole bespoke string-based option parsing in the
first commit. Why not use named arguments for this, i.e. have the
usage syntax be:

SELECT * FROM pg_get_role_ddl('regress_role_ddl_test3', pretty => true);

Instead of the current:

SELECT * FROM pg_get_role_ddl('regress_role_ddl_test3', 'pretty', 'true');

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2026-04-05 18:13:51 Re: Stack-based tracking of per-node WAL/buffer usage
Previous Message Antonin Houska 2026-04-05 16:30:41 Re: Adding REPACK [concurrently]