| From: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
|---|---|
| To: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Reorganize pqcomm.h a bit |
| Date: | 2025-11-21 21:39:12 |
| Message-ID: | CAGECzQRpY8rxgkUPtA6Z1YojeT8Yy=Gn3i5rmn0CiV3dvY+YsA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 21, 2025, 12:10 Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
wrote:
>
> WDYT?
>
Overall seems like reasonable restructuring. I think this note feels out of
place now though:
* The cancel request code must not match any protocol version number
* we're ever likely to use. This random choice should do.
I think it'd be better to remove that paragraph and maybe extend the
section intro to be something like this (feel free to change/ignore as you
see fit):
Reserved protocol version numbers. These don't denote an actual protocol
version but instead have special semantics. These version numbers will
never be used as an actual protocol version.
Finally, the newline addition at line 71 I don't understand the purpose of.
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2025-11-21 22:01:19 | Re: [PATCH] Reorganize pqcomm.h a bit |
| Previous Message | Corey Huinker | 2025-11-21 21:31:23 | Re: Import Statistics in postgres_fdw before resorting to sampling. |