| From: | Jelte Fennema <me(at)jeltef(dot)nl> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | jian he <jian(dot)universality(at)gmail(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Dmitry Igrishin <dmitigr(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Daniele Varrazzo <daniele(dot)varrazzo(at)gmail(dot)com> |
| Subject: | Re: Deleting prepared statements from libpq. |
| Date: | 2023-06-19 09:44:52 |
| Message-ID: | CAGECzQRp1SpFPWL-S28oS=FAR3L_wOz4Uowo7rzNsU2eGcmEBQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 19 Jun 2023 at 01:57, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> +static int
> +PQsendClose(PGconn *conn, char close_type, const char *close_target)
>
> Could it be better for this code path to issue an error if using a
> non-supported close_type rather than sending it? Okay, you are
> consistent with desc_type and PQsendDescribe(), just asking if it is
> worth doing something about.
Since it's not a publicly exposed function, I think it's fine as is.
Seems easy enough to make sure libpq itself doesn't call it with
unsupported arguments. And even if someone would do that accidentally,
the server would report an error.
> Perhaps there should be some tests for the two async routines, as
> well?
Done
I also fixed all the typos/docs changes you and Jian mentioned, as
well as improving some of the new docs myself.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jelte Fennema | 2023-06-19 09:46:58 | Re: Deleting prepared statements from libpq. |
| Previous Message | Amit Kapila | 2023-06-19 09:34:07 | Re: Support logical replication of DDLs |