| From: | Jelte Fennema <postgres(at)jeltef(dot)nl> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Ian Lawrence Barwick <barwick(at)gmail(dot)com>, Greg Stark <stark(at)mit(dot)edu>, David Christensen <david(dot)christensen(at)crunchydata(dot)com>, "Imseih (AWS), Sami" <simseih(at)amazon(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] pgbench: add multiconnect option |
| Date: | 2023-01-06 10:44:52 |
| Message-ID: | CAGECzQRYGn7u=VAtqd7dQpnxkoS4k1YGE8VDvd3QvTYUtK-vvw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
This patch seems to have quite some use case overlap with my patch which
adds load balancing to libpq itself:
https://www.postgresql.org/message-id/flat/PR3PR83MB04768E2FF04818EEB2179949F7A69(at)PR3PR83MB0476(dot)EURPRD83(dot)prod(dot)outlook(dot)com
My patch is only able to add "random" load balancing though, not
"round-robin". So this patch still definitely seems useful, even when mine
gets merged.
I'm not sure that the support for the "working" connection is necessary
from a feature perspective though (usability/discoverability is another
question). It's already possible to achieve the same behaviour by simply
providing multiple host names in the connection string. You can even tell
libpq to connect to a primary or secondary by using the
target_session_attrs option.
On Fri, 6 Jan 2023 at 11:33, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
>
> Hello Ian,
>
> > cfbot reports the patch no longer applies. As CommitFest 2022-11 is
> > currently underway, this would be an excellent time to update the patch.
>
> Attached a v5 which is just a rebase.
>
> --
> Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2023-01-06 11:28:10 | Re: Improve tab completion for ALTER FUNCTION/PROCEDURE/ROUTINE |
| Previous Message | tushar | 2023-01-06 10:41:34 | Re: Getting an error if we provide --enable-tap-tests switch on SLES 12 |