| From: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
|---|---|
| To: | Maciek Sakrejda <m(dot)sakrejda(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Isaac Morland <isaac(dot)morland(at)gmail(dot)com>, Greg Sabino Mullane <htamfids(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Joel Jacobson <joel(at)compiler(dot)org>, Gabriele Bartolini <gabriele(dot)bartolini(at)enterprisedb(dot)com>, Magnus Hagander <magnus(dot)hagander(at)redpill-linpro(dot)com> |
| Subject: | Re: Possibility to disable `ALTER SYSTEM` |
| Date: | 2024-03-27 23:43:29 |
| Message-ID: | CAGECzQRP7qq3qX-WmPwDKH6PtNzkj77xVYJs-dWtq0PR_GVS3A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 27 Mar 2024 at 20:10, Maciek Sakrejda <m(dot)sakrejda(at)gmail(dot)com> wrote:
>
> On Wed, Mar 27, 2024, 11:46 Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>
>> On Wed, Mar 27, 2024 at 1:12 PM Isaac Morland <isaac(dot)morland(at)gmail(dot)com> wrote:
>> > On Wed, 27 Mar 2024 at 13:05, Greg Sabino Mullane <htamfids(at)gmail(dot)com> wrote:
>> >>> The purpose of the setting is to prevent <emphasis>accidental</emphasis> modifications via <literal>ALTER SYSTEM</literal> in environments where
>> >> The emphasis on 'accidental' seems a bit heavy here, and odd. Surely, just "to prevent modifications via ALTER SYSTEM in environments where..." is enough?
>> > Not necessarily disagreeing, but it's very important nobody ever mistake this for a security feature. I don't know if the extra word "accidental" is necessary, but I think that's the motivation.
>>
>> I think the emphasis is entirely warranted in this case.
>
> +1. And while "non-malicious" may technically be more correct, I don't think it's any clearer.
Attached is a new version of the patch with some sentences reworded. I
changed accidentally to mistakenly (which still has emphasis). And I
hope with the rewording it's now clearer to the reader why that
emphasis is there.
| Attachment | Content-Type | Size |
|---|---|---|
| v9-0001-Add-allow_alter_system-GUC.patch | application/octet-stream | 6.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2024-03-27 23:46:28 | Re: Crash on UNION with PG 17 |
| Previous Message | Imseih (AWS), Sami | 2024-03-27 23:08:24 | Re: Psql meta-command conninfo+ |