Re: Speed up clean meson builds by ~25%

From: Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Subject: Re: Speed up clean meson builds by ~25%
Date: 2024-04-08 08:59:17
Message-ID: CAGECzQR3HPMy99ooWd=zcQ3wd=kiTP4Or6F7V8+BtOi2a1yFJQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 8 Apr 2024 at 10:02, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> I have tested this with various compilers, and I can confirm that this
> shaves off about 5 seconds from the build wall-clock time, which
> represents about 10%-20% of the total time. I think this is a good patch.

Great to hear.

> Interestingly, if I apply the analogous changes to the makefiles, I
> don't get any significant improvements. (Depends on local
> circumstances, of course.) But I would still suggest to keep the
> makefiles aligned.

Attached is a patch that also updates the Makefiles, but indeed I
don't get any perf gains there either.

On Mon, 8 Apr 2024 at 07:23, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> Well, this is also painful with ./configure. So, even if we are going
> to move away from it at this point, we still need to support it for a
> couple of years. It looks to me that letting the clang folks know
> about the situation is the best way forward.

I reported the issue to the clang folks:
https://github.com/llvm/llvm-project/issues/87973

But even if my patch doesn't help for ./configure, it still seems like
a good idea to me to still reduce compile times when using meson while
we wait for clang folks to address the issue.

Attachment Content-Type Size
v2-0001-Speed-up-clean-parallel-meson-builds-a-lot.patch application/octet-stream 3.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Lakhin 2024-04-08 09:00:00 Re: Speed up clean meson builds by ~25%
Previous Message Michael Paquier 2024-04-08 08:55:55 Re: Weird test mixup