Re: CI: Add task that runs pgindent

From: Jelte Fennema-Nio <me(at)jeltef(dot)nl>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Florents Tselai <florents(dot)tselai(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
Subject: Re: CI: Add task that runs pgindent
Date: 2025-10-22 08:41:49
Message-ID: CAGECzQQJgGqwkgHWdH8TxVKg4Gdb-PjK_F0+PpzjB4JUL_87yA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 21 Oct 2025 at 16:49, Jelte Fennema-Nio <me(at)jeltef(dot)nl> wrote:
> By having it be a separate job I can easily make the
> cfbot and commitfest app report it as "yellow" instead of "red" if
> this job fails.

I set "allow_failures: true" in the cirrus task, so that a formatting
failure won't show the whole build as failed. I updated the commitfest
app to now show it with an orange cross instead of a red one (see
attached png). I included a patch that breaks indentation so I can
easily test this new behaviour end-to-end.

Attachment Content-Type Size
v2-0001-CI-Add-task-that-runs-pgindent.patch text/x-patch 2.7 KB
v2-0002-Wrong-indent-to-test-job.patch text/x-patch 874 bytes
image/png 16.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-10-22 08:44:38 Re: Add wal_fpi_bytes_[un]compressed to pg_stat_wal
Previous Message Hayato Kuroda (Fujitsu) 2025-10-22 08:30:41 RE: POC: enable logical decoding when wal_level = 'replica' without a server restart