| From: | Jelte Fennema <postgres(at)jeltef(dot)nl> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kirk Wolak <wolakk(at)gmail(dot)com>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: proposal: psql: show current user in prompt |
| Date: | 2023-09-03 07:59:33 |
| Message-ID: | CAGECzQQAKwSvhjUpqUuQnN+EkTh6T6A1FTP9fscrJfP1XB0DUw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, 3 Sept 2023 at 08:24, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
> My personal feeling from this area is that the protocol design is done, but it is not implemented on libpq level. My feelings can be wrong. The protocol number is hardcoded in libpq, so I cannot change it from the client side.
No, I agree you're right the client side code to fall back to older
versions is not implemented. But that seems fairly simple to do. We
can change pqGetNegotiateProtocolVersion3 its behaviour. That function
should change conn->pversion to the server provided version if it's
lower than the client version (as long as the server provided version
is 3.0 or larger). And then we should return an error when calling
PQlinkParameterStatus/PQunlinkParameterStatus if the pversion is not
high enough.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2023-09-03 10:04:00 | Re: Inefficiency in parallel pg_restore with many tables |
| Previous Message | Pavel Stehule | 2023-09-03 06:23:27 | Re: proposal: psql: show current user in prompt |