| From: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
|---|---|
| To: | Niv Green <nivgreen(at)proton(dot)me> |
| Cc: | "pgadmin-hackers(at)lists(dot)postgresql(dot)org" <pgadmin-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Request for review: pgAdmin 4 PR #10142 - Custom Geometry Viewer tile provider |
| Date: | 2026-07-23 13:23:01 |
| Message-ID: | CAG7mmozqC1B+6up8X4-o4XG4V9e1U9vny2ZiGpubD6ifTUhWMA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
I will review and get back to you.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com>
*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>
On Thu, Jul 23, 2026 at 6:44 PM Niv Green <nivgreen(at)proton(dot)me> wrote:
> Hello pgAdmin developers,
>
> I recently opened pull request #10142:
>
> https://github.com/pgadmin-org/pgadmin4/pull/10142
>
> The PR adds configurable custom XYZ tile providers to the Geometry Viewer,
> including settings for the provider URL, name, CRS, attribution, and
> maximum zoom.
>
> It also:
>
> - Preserves the existing built-in base layers when they are compatible.
> - Supports providers using EPSG:3857, EPSG:4326, or EPSG:3395.
> - Hides incompatible built-in layers when a non-Web Mercator CRS is
> selected.
> - Includes JavaScript regression tests and documentation updates.
>
> The PR has been open since July 5, but I have not yet received feedback
> from a project maintainer. I understand that pgAdmin is maintained by
> volunteers and that review time is limited, but I would appreciate it if
> someone could take an initial look or help triage it.
>
> In particular, please let me know whether the overall approach fits the
> project, whether any architectural changes are needed, or whether I should
> request a specific reviewer.
>
> I am happy to address any feedback or make further changes.
>
> Thank you for your time,
>
> Niv Greenstein
> GitHub: @NivGreenstein
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashesh Vashi | 2026-07-24 17:25:48 | Re: Request for review: pgAdmin 4 PR #10142 - Custom Geometry Viewer tile provider |
| Previous Message | Niv Green | 2026-07-23 07:34:31 | Request for review: pgAdmin 4 PR #10142 - Custom Geometry Viewer tile provider |